tde-devs@chat.jabb.im < 2021/06/30 >
[02:10]michelec2 has joined
[02:29]michelec2: @Greg: knemo works fine when we use the "sys" backend. Great finding!!
[02:30]michelec2: good that someone wrote on the list and you decided to check this out!
[02:30]michelec2: I sugeest we change the default backend to "sys" in the code. What do you think?
[02:36]michelec2 has left
[07:59]blu.256: Should I squash and merge TDE/tdenetwork#34? I have tested this with success.
[07:59]tde-bot: [TGW][tdenetwork] #34 - Kopete videodevice fixes
https://mirror.git.trinitydesktop.org/gitea/TDE/tdenetwork/pulls/34
[08:00]Slávek: Yes, it seems good to me and ready for squash and move forward.
[08:01]blu.256: okay
[08:05]blu.256: merged and backported!
[08:06]Slávek: Great, good work. Thank you.
[08:19]Slávek: It seem, another fix will be necessary - I started builds and it cause FTBFS:
[08:20]Slávek: ../kopete/plugins/motionautoaway/motionawayplugin.cpp:113:7: error: 'VIDEO_PALETTE_RGB24' was not declared in this scope
VIDEO_PALETTE_RGB24);
^~~~~~~~~~~~~~~~~~~
[08:21]Slávek: and another problem on FreeBSD:
[08:21]Slávek: ../kopete/libkopete/avdevice/videodevice.cpp:62:19: error: out-of-line definition of 'enumerateMenu' does not match any declaration in 'Kopete::AV::VideoDevice'
void VideoDevice::enumerateMenu (void)
^~~~~~~~~~~~~
[08:31]Slávek: FTBFS is not dependent on the distribution version, nor the branch - occurs on all distributions on both branches - master as well as r14.0.x.
[08:43]blu.256: strange, builds okay for me... looks like a few #ifdef's are needed because VIDEO_PALETTE_RGB24 is from V4L while enumerateMenu is from V4L2
[08:47]Slávek: It seems that VIDEO_PALETTE_* is from V4L1 compatility layer.
[08:49]Slávek: You build MotionAway plugin?
[08:51]blu.256: Probably not
[08:52]blu.256: Well, I have pushed some fixes to fix/kopete-video-ftbfs branch for testing
[08:52]Slávek: Now I see that in libkopete/avdevice/videodevice.h is used:
#if defined(__LINUX_VIDEODEV2_H) /* V4L2 */
[08:53]blu.256: Yes, I just fixed this
[08:53]Slávek: This will be the beginning of the problem on FreeBSD.
[08:54]blu.256: The problem with motionaway, seems that it was never updated for V4L2
[08:54]blu.256: VIDEO_PALETTE_RGB24 is from V4L1
[08:56]blu.256: Can you please test from fix/kopete-video-ftbfs branch?
[08:56]Slávek: I'll try commit in a while. Now first breakfast and other minor things :)
[08:59]blu.256: Okay :)
[09:57]Slávek: /root/tdenetwork-trinity-14.0.11~pre11/kopete/plugins/motionautoaway/motionawayplugin.cpp:116:3: error: 'VIDEO_PALETTE_RGB24' was not declared in this scope
VIDEO_PALETTE_RGB24);
^~~~~~~~~~~~~~~~~~~
[09:57]Slávek: next to this also some other problems:
[09:58]Slávek: /root/tdenetwork-trinity-14.0.11~pre11/kopete/plugins/motionautoaway/motionawayplugin.cpp: In member function 'int MotionAwayPlugin::getImage(int, TQByteArray&, int, int, int, int, int)':
/root/tdenetwork-trinity-14.0.11~pre11/kopete/plugins/motionautoaway/motionawayplugin.cpp:149:26: error: aggregate 'MotionAwayPlugin::getImage(int, TQByteArray&, int, int, int, int, int)::video_capability vid_caps' has incomplete type and cannot be defined
struct video_capability vid_caps;
^~~~~~~~
[09:59]Slávek: ...and some ioctl calls:
[09:59]Slávek: /root/tdenetwork-trinity-14.0.11~pre11/kopete/plugins/motionautoaway/motionawayplugin.cpp:157:19: error: 'VIDIOCGCAP' was not declared in this scope
if (ioctl (_dev, VIDIOCGCAP, &vid_caps) == -1)
^~~~~~~~~~
[10:16]Slávek: For FreeBSD, is a good move forward, so that now there is the same problem with MotionAway plugin, as on Linux.
[11:23]cethyel has joined
[11:46]cethyel: Hi Slávek, @kopete-otr, you might don't like It https://mirror.git.trinitydesktop.org/gitea/TDE/kopete-otr/commit/61665a20a59be4cc94f868949a7edb85136c036a but I don't experience any crash with this build solution
[11:56]Slávek: Yes, it doesn't look good because it causes all three libraries contain essentially all code again and again.
[11:59]Slávek: During lunch I gained one more idea ... I'll try what the result will be.
[12:10]Slávek: Greg, you can try updated patch.
[12:15]cethyel: ok let's see, I was going to build with automake then list all shared stuff and symbols, hope your solution help because listing everything to compare with the recent work, was not so appealing :-/
[12:19]Slávek: I haven't tested whether there really is necessary KDE_EXPORT for all classes - I just left it. A substantial change is to move the OTRPlugin object code as such from the library to the module.
[12:21]cethyel: at least It doesn't crash anymore, taping from kopete right now
[12:22]cethyel: I usually leave the otr plugin selected so kopete crashes (used to) right off the bat
[12:22]Slávek: At the same time I noticed Generate button in the OTR plugin configuration.
[12:23]Slávek: I'm not sure whether I saw this button there in the version that caused crashes.
[12:24]Slávek: It seems that the current solution retains a clear code arrangement and it works at the same time.
[12:25]cethyel: i don't noticed that either, i pushed it once (was looking for an animation), it does generate a new key
[12:27]Slávek: I hesitate to reduce KDE_EXPORT to only necessary...
[12:28]Slávek: ...or whether to keep it as it is in patch now.
[12:29]cethyel: I don't know what is strictly needed, I usually rely on the compiler to tells me but here It builds fine no FTBFS, or I see a crash then I look for C functions to be exported
[12:36]blu.256: @MotionAway I managed to solve the FTBFS problem by adding code for handling V4L2, based on code from libkopete/avdevice/videodevice.cpp. I've pushed a new commit to fix/kopete-video-ftbfs with the changes. Haven't thoroughly tested it yet.
[12:37]cethyel: blu.256 if you have some spare time can you tell me if Knemo and Knetload are working on your system (Arch)?
[12:37]Slávek: gread, I'll try to build again.
[12:49]blu.256: @cethyel Will try to build them and then report back
[12:50]Slávek: Ok, Greg, you can try a new version of patch. This reduces back virtually all KDE_EXPORT.
[12:52]cethyel: Thanks very much :yes:, you might have to config Knemo to work with the Sys backend see my post here: https://mail.trinitydesktop.org/mailman3/hyperkitty/list/users@trinitydesktop.org/message/G4HY3S4ZDU472IC6E3YTCCDISXMY3PQV/
[12:52]tde-bot: Page Not Found - TDE Gitea Workspace
https://mirror.git.trinitydesktop.org/gitea/list/users/commit/trinitydesktop
[12:55]Slávek: It seems that tde-bot need further tightening of regular expressions to avoid unexpected reactions :)
[12:58]blu.256: KNemo: works with sys, but not with net-tools, which BTW is required for building KNemo
[13:04]cethyel: @knemo, well I try to mimic the automake build as close as possible, at the time knemo was written, net-tools were the default backend, Sys (linux filesystem) was new, maybe now this backend (net-tools) can be optional
[13:05]blu.256: KNetload: IN and OUT are zero as by default it uses eth0 for some reason. Trying to change it to enp3s0 via context menu hangs KNetload
[13:05]cethyel: @kopete-otr, new crash this time not when I enable the plugin but when I start a chat
[13:05]cethyel: @knetload, same behavior here
[13:06]blu.256: maybe eth0 is hardcoded somewhere?
[13:06]cethyel: yes
[13:06]blu.256: I don't even have such a network interface
[13:10]Slávek: Greg, did you test TDE/kopete-otr@67b3362960?
[13:10]tde-bot: [TGW][kopete-otr] Move OTRPlugin object code into kopete_otr module. · 67b3362960
https://mirror.git.trinitydesktop.org/gitea/TDE/kopete-otr/commit/67b3362960
[13:11]Slávek: I tried it on my testing machine and there was no crash.
[13:15]cethyel: @kopete-otr, close the chat, select the plugin ON, close kopete, start kopete then get online, here it crashes
[13:17]cethyel: knetload, I guess this have to go: https://mirror.git.trinitydesktop.org/gitea/TDE/knetload/src/branch/master/knetload/knetload.cpp#L38
[13:28]cethyel: guys, thanks for everyone contributions and help :yes: but I'm going for now, see you later
[13:28]cethyel has left
[14:24]Slávek: Blu.256, tdenetwork with added patches built successfully to Debian Stretch and also FreeBSD.
[14:24]Slávek: Note, you can move ") == m_width * m_height *3 )" outside #ifdef?
[14:26]Slávek: This is to prevent repetition of parentheses and code that is the same, inside #ifdef.
[14:34]Slávek: Greg, it's weird. I do not observe crash when I enable plugin even when I open a chat window, but after some longer time - I don't know if after some event.
[15:13]blu.256: @Slávek repetition removed
[15:20]Slávek: Great, it seems that it can be squashed and merged.
[15:21]blu.256: ok
[15:23]blu.256: Squashed. Should I create a PR in TGW or can I just merge it via command line?
[15:26]Slávek: Because we've already done testing outside PR, you can merge it in CLI.
[15:47]blu.256: done
[15:50]Slávek: builds for PSB and PTB repositories started :)
[15:53]Slávek: ... and the first builds are completed successfully.
[15:54]Slávek: It's great that it has been resolved quickly, and at the same time there has been added V4L2 support in MotionAway plugin.
[15:54]Slávek: Thank you!
[15:54]blu.256: My pleasure!
[15:56]blu.256: BTW there is also blu.256/twin-style-dekorator which can be added to TDE.
[15:56]blu.256: (if everything is okay there)
[15:56]Slávek: Yes, as far as I know, Michele has it in his todo list.
[15:57]blu.256: Okay, just a little reminder ;)
[15:57]Slávek: (Y)
[20:32]Slávek has left
[20:34]Slávek has joined
[21:01]Slávek: It seems that I managed to definitely solve the crashes caused by kopete-otr plugin.
[21:47]cethyel has joined
[21:49]cethyel: @kopete-otr, I don't have any crash with your last push (Y)
[21:49]Slávek: Great!
[21:49]Slávek: The same for me... OTR plugin is now active on my machine, in this session.
[21:50]cethyel: how do i know it works?
[21:52]cethyel: did you get all those "authentification error!"?
[21:53]Slávek: Yes, I also got many Authentication error.
[21:54]Slávek: Probably the result of the fact that I tried to invoke contact authentication and then cancelled it.
[22:01]cethyel has left
[22:02]cethyel has joined
[22:03]cethyel: when you start to "authenticate contact" but you don't enter the passphrase we see these endless errors
[22:05]Slávek: Authentication of contact for OTR probably assume that by some other channel we will have the agreed password to verify.
[22:05]cethyel: yes i read something like that from the manual for kopete (pdf version)
[22:06]cethyel: there's a chapter with otr plugin
[22:08]Slávek: In any case, it is good news that OTR really works :)
[22:09]cethyel: I'm quite happy with Ubuntu btw, I can profit from your packages and use my scripts, this system runs well on a raid0, I'll keep this old station for an other year I believe :-D
[22:11]Slávek: :)
[22:11]cethyel: I'm logging off, I just wanted to try your last commit :-) bye, see you later!
[22:11]Slávek: thanks
[22:11]Slávek: see you
[22:11]cethyel has left

tde-devs@chat.jabb.im < 2021/06/30 >