tde-devs@chat.jabb.im < 2021/08/10 > |
[01:16] | michelec2 has joined |
[01:18] | michelec2 has left |
[01:19] | michelec2 has joined |
[01:41] | tde-bot has left |
[05:49] | tde-bot has joined |
[05:55] | blu.256 has joined |
[06:32] | Slávek has joined |
[08:09] | michelec2 has joined |
[09:18] | Slávek has left |
[10:07] | Slávek has joined |
[11:40] | cethyel has joined |
[11:41] | cethyel has left |
[11:42] | cethyel has joined |
[12:15] | cethyel: Hi Slávek, what do you think of making libisofs a shared lib? libisofs is built as a static lib in three modules namely: tdelibs, krusader, k3b. Something in the same vein we did for (t)qca and tdenetwork. One can note that the libisofs lib which is embedded in TDE's modules is not the one from the libburnia project, furthermore as I said 2 years ago we have the 0.2 version while the 0.4 is available in sourceforge https://sourceforge.net/projects/libcdrom/files/libisofs/0.4/ |
[12:19] | michelec2: perhaps it could make sense to move it to a standalone common module like liblttd or libtdevnc? What do you think? |
[12:20] | cethyel: in the dependencies? |
[12:20] | michelec2: in common folder |
[12:20] | Slávek: Do not forget that libltdl and libtdevnc are not built as shared, but static - embedded. |
[12:20] | michelec2: then added as dependency to those modules for building |
[12:21] | michelec2: or maybe in dependency is better, if it is independent of tde code |
[12:22] | Slávek: Here it seems like a good idea to either do something like shared libtdeisofs that can be used in all modules (linked as shared) - a or use another existing libisofs (libburnia). |
[12:22] | cethyel: genuine question here, why making a standalone module in commun, why do we have these two modules there? |
[12:23] | Slávek: 'common' doesn't seem like a suitable place. |
[12:24] | Slávek: Both libltdl and libtdevnc are statically built within the modules, not linked to shared. |
[12:24] | cethyel: a agree, but why are libltd and libtdevnc in commun btw? |
[12:26] | Slávek: For libtdevnc there, the question is whether adjustments compared to upstream libvnc are needed or can be maintained in another way other than "fork" libvnc. |
[12:27] | Slávek: I remember that some work on lib(tde)isofs was already done - I have the appropriate branch saved, in order to continue this direction. |
[12:29] | cethyel: I prefer starting anew as a standalone module in the "dependencies" folder, then making changes in tdelibs, krusader and k3b |
[12:41] | michelec2: if libisofs does not depends on TQt/TDE, we can place it in the dependency folder |
[12:42] | michelec2: I think we can call it libisofs, I see no reason to call it libtdeisofs unless there is anything specific to TDE. |
[12:44] | michelec2: re common folder: good point Greg. Probably we should consider moving the modules in there in other places. For example, cmake we could call it cmake-trinity and move it to dependency IMO |
[12:45] | michelec2: what do you think? |
[12:46] | michelec2: common admin module at some point will be dropped and the other modules we can also move to dependency/libraries depending on whether they have tq/tde specific dependency or not |
[12:47] | Slávek: One libisofs
https://sourceforge.net/projects/libcdrom/files/libisofs/0.4/ |
[12:47] | Slávek: Second libisofs
https://en.wikipedia.org/wiki/Libburnia |
[12:47] | cethyel: @libisofs, I don't know yet if tdelibs, krusader and k3b will need header(s) from libisofs, probably along the way they will need some, so libisofs should be renamed |
[12:48] | Slávek: Therefore, there may be somewhat impractical to use the name libisofs. |
[12:49] | Slávek: https://packages.debian.org/buster/libisofs-dev |
[12:49] | tde-bot: Page title: Debian -- Details of package libisofs-dev in buster |
[12:51] | cethyel: @cmake-trinity, yes It make sense to move It in "dependencies" with It's real name cmake-trinity, It's cleaner that way |
[12:56] | michelec2: maybe we can check if we can use libisofs from the distros instead of maintaining our own version. assuming they come from the same original development |
[12:57] | michelec2: if they are different code base instead, then we can have our own copy and use that |
[12:57] | michelec2: @cmake-trinity: yes, just waiting the approval from the boss (@Slavek) :-D |
[12:58] | michelec2: @Greg: I am almost done with tdehw. I should have a PR ready by tomorrow or thursday |
[12:59] | cethyel: do you need some testing from a Slackware OS perspective? |
[13:04] | cethyel: washing machine has stopped, I'm drying out my clothes off the balcony, be back in minutes... |
[13:08] | michelec2: yes, it will be good if you can do some testing on your system too to see if you spot any problem |
[13:09] | michelec2: the update mechanism of devices has been revised quite a bit and now it is more lean and avoiding lot of repetition work |
[13:16] | cethyel: do you have something in mind for the testing? such as looking for USB, SD cards, etc |
[13:22] | michelec2: you can try mount/unmounting disks with differnet partitions. I will write more in the PR when ready |
[13:23] | michelec2: and if you have LUKS disks to test, even better |
[13:37] | michelec2: will be offline for an hour or for the night |
[13:38] | michelec2: have a good evening everyone |
[13:38] | Slávek: thanks, good night to you |
[13:38] | cethyel: sleep tight! |
[13:39] | michelec2: thanks |
[13:39] | michelec2 has left |
[13:54] | cethyel: I'm going, see you later |
[13:54] | cethyel has left |
[15:17] | cethyel has joined |
[15:22] | cethyel: Slávek, I should have asked you to send me a tarball of my previous work on libisofs, I wouldn't have spent some time on a FTBFS, I've just remember that we have to add few extern declarations on some online functions in isofs.c :-/ |
[15:26] | Slávek: Diff (commit) can be sufficient? |
[15:29] | cethyel: sure, I can have a look at It, I'm just amazed that I could remember this trick, this is unexpected from me :-[ |
[15:36] | cethyel: got It, thanks! |
[15:55] | cethyel has left |
[16:45] | Slávek has left |
[17:28] | Slávek has joined |
[17:45] | Slávek has left |
[22:02] | Slávek has joined |
tde-devs@chat.jabb.im < 2021/08/10 > |