tde-devs@chat.jabb.im < 2021/08/13 >
[01:49]michelec2 has joined
[02:56]michelec2: @Greg: tdedocker and tdeio-gopher didn't need any automake removal, so I have marked them completed in TDE/tde#11. If you have a look and there is anything you want to change (install file, readme and so on) you can just prepare a PR and I will merge.
[02:56]tde-bot: [TGW][tde] #11 - Automake files and admin module removal
https://mirror.git.trinitydesktop.org/gitea/TDE/tde/issues/11
[06:56]michelec2 has left
[06:56]michelec2 has joined
[07:03]blu.256 has left
[09:12]Slávek: I did a small test of TDE/tdelibs#144 on my test machine.
[09:12]tde-bot: [TGW][tdelibs] #144 - tdehw lib: reworked device notifications to avoid repeated scanning of devices.
https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/pulls/144
[09:12]Slávek: I tested the insertion of the CD-Rom.
[09:12]Slávek: I have a problem because udisks2 rejects mount. However, notification about inserting the media is displayed correctly.
[09:13]Slávek: When I try eject, it doesn't report any problem, but it doesn't do anything.
[09:14]Slávek: When I remove the media manually, the icon disappears, but the tray applet does not show any notification.
[09:21]Slávek: Is it okay that there is no notification when the medium is removed?
[09:22]michelec2: not really,there should be a notification
[09:22]michelec2: by "remove manually" do you mean by pressing the button on the cd rom reader?
[09:23]michelec2: @notification: as long as udev gives a notification, then there should be a notification also in tdehwdevicetray.
[09:23]Slávek: Yes, basically like pressing a button - it's a virtual machine, so typing the command from the host.
[09:23]michelec2: ah ok. I see something similar with virtualbox and "forced removed"
[09:23]michelec2: nothing hanppens in that case, no notification
[09:24]michelec2: I can make a test on a real laptop with real CDrom this weekend perhaps, I need to cross build for i386 first
[09:24]Slávek: But the icon disappears properly, so there will be some event.
[09:24]michelec2: oh, that's different. here the icon does not disapper, so I thought VB was not informing the OS of the forced removal
[09:25]michelec2: btw why does umount2 reject mounting it?
[09:25]michelec2: it is weird
[09:25]michelec2: assuming you are testing on R14.1.0, I mean
[09:28]Slávek: There seems to be there any problem because of policykit. When it is installed, I get the message that I don't have permissions. When it is not installed, I get the message that policykit is not available and I'm not uid 0.
[09:29]michelec2: I think policykit is regardless of PR
[09:29]Slávek: Yes, R14.1.0~pre on Buster.
[09:29]michelec2: we already know we need a user agent for policykit
[09:30]Slávek: Yes, the problem with udisks2 × policykit is not related to this PR.
[09:30]michelec2: (y)
[09:31]Slávek: I'm afraid that the need to create a policykit agent is urgent :(
[09:31]michelec2: it is interesting that icon disaepper but you have no notification
[09:32]michelec2: because they are triggered by the same event
[09:33]michelec2: as for policykit we will need the agent for R14.1.0 for sure
[09:36]Slávek: I assume the agent will also be needed for R14.0.x.
[09:36]Slávek: Previously, we could rely on "onConsole" - ie Consolekit.
[09:36]michelec2: wow, so bad? what has changed that we now need it so urgently?
[09:37]michelec2: the work around with the plugdev group is no longer good enough?
[09:38]Slávek: But with the newer Systemd, Consolekit is history and then it depends on whether the services ignore the absence of policykit or whether require policykit => the agent is needed in that case.
[09:39]Slávek: workaround with plugdev group is sufficient for our tdehw dbus daemon, but not for other services.
[09:39]michelec2: I see. probably because I am usually root, I don't see so many issue
[09:40]michelec2: in any case, there are only few actions for R14.1.0, so policykit agent is in the roadmap soon
[09:40]Slávek: Yes exactly. But we must think of ordinary users :)
[09:40]michelec2: yeah
[09:47]michelec2: I will put in on the TODO list for after R14.0.11 release.
[09:47]michelec2: before I have other things to do in the list
[09:48]Slávek: I'm afraid that this causes problems to users with Buster and will cause problems to users with Bullseye, which should be released soon.
[09:49]michelec2: ah ok, I will see if I can do something before that then
[09:49]Slávek: org.freedesktop.UDisks2.Error.NotAuthorizedCanObtain: Not authorize to perform operation.
[09:50]michelec2: yes, I understand
[09:51]Slávek: There is a need to use either another method (pmount, which is not too good alternative) or to hack the udisk2 configuration :(
[09:52]michelec2: pmount is limited. the best is defintely to have a policykit user agent, IMO
[09:55]Slávek: Yes, policykit is definitely a suitable solution.
[09:55]michelec2: (y)
[10:02]michelec2: I have two questions
[10:03]michelec2: when you eject the cdrom and the icon disapper from the desktop, what do you see in konqueror? does the icon also disapper?
[10:04]michelec2: and in tdehwdevicetray what do you see? is the icon still present in any of the submenu for devices?
[10:04]Slávek: In fact, I didn't look at the desktop, but on the window of media:/ in Konqeuror.
[10:04]michelec2: ah ok, in any case konqueror and kdesktop share many things, it should be the same. maybe next time you can double check on kdesktop too, if you have icons there
[10:05]Slávek: In Tray application items for CD-ROM are then not listed.
[10:05]michelec2: that is correct. I wonder why there is no notification though.
[10:05]Slávek: Now I'm going to try tdelibs + tdebase without patches from current PRs.
[10:06]michelec2: (y) that was my next question :-)
[10:06]michelec2: is the CDrom a data CD with file system? or audio cd? or empty cd?
[10:06]Slávek: Slax with Trinity :)
[10:06]michelec2: (y) same iso that I use for testing :-D
[10:20]Slávek: Test performed - with the previous version I see notification of removal /dev/sr0.
[10:21]Slávek: Weird is that I don't get the icon on the desktop.
[10:23]michelec2 has left
[10:23]michelec2 has joined
[10:37]michelec2: ok, I see if I can replicate the problem here somehow.
[10:38]michelec2: the icon on desktop could be disabled maybe for specific mimetype
[10:48]michelec2: @Slavek: could you try adding some logging at the beginning of processHotPluggedHardware() to see if you get notified when the cd rom is removed?
https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/src/commit/f159fa61a972641944adc614d33baf5e52ac5e0e/tdecore/tdehw/tdehardwaredevices.cpp#L387
[10:48]michelec2: this will help understanding if the problem is with the notifications code or with a missing event
[10:51]michelec2: suggest you print the pid as well to help you identify which process is printing, otherwise it can get a bit confusing to follow the logs (unless you run tdehwdevicetray from CLI)
[10:52]Slávek: The icon is probably really related to MIME type - when I tried to attach another ISO, it is displayed on the desktop.
[10:54]michelec2: uhm... that't a bit weird. in any case you can enable/disable the displayed icon mime types to be sure
[10:58]michelec2: I did a test with VB and when I force removed the ISO cdrom there is no udev event, hence no user notification. The same behavior was with old code too though
[10:58]michelec2: if would be helpful if you can do the test above so we have some extra data
[10:59]Slávek: Yes, I'll add logging to see the difference.
[10:59]michelec2: (y) thanks
[11:01]michelec2: also, can you also check in kdcop -> kded -> mediamanager -> fulllist() if the device is present or if has disappeared?
[11:22]blu.256 has joined
[13:34]cethyel has joined
[14:08]Slávek: When medium is plugged in:
[14:08]michelec2: yes
[14:08]Slávek: [2021/08/13 16:06:44.115] [hwdevicetray] WARNING: processHotPluggedHardware: change
[14:08]Slávek: [2021/08/13 16:06:44.204] [hwdevicetray] WARNING: processHotPluggedHardware: change
[14:09]Slávek: When medium is removed:
[14:09]Slávek: [2021/08/13 16:07:22.558] [hwdevicetray] WARNING: processHotPluggedHardware: change
[14:09]Slávek: [2021/08/13 16:07:22.738] [hwdevicetray] WARNING: processHotPluggedHardware: change
[14:09]michelec2: change events?
[14:09]michelec2: not add and remove?
[14:09]michelec2: Hi Greg, thanks for new PR
[14:10]Slávek: Remember that this is the insertion of the media into the dvd drive, not connecting / disconnecting the drive as a whole.
[14:10]michelec2: ah good point!
[14:10]michelec2: I shall double check the same is true here as well
[14:11]cethyel: Hi Michele, I don't get to view the help page in tde-systemsettings, page is not found, before you go to bed, can check this out on your system?
[14:11]michelec2: in such case it seems to be a bug if you don't get the notification, since the even is triggered
[14:11]michelec2: @Greg: from TCC?
[14:12]cethyel: tde-systemsettings appears in settings as it own i believe
[14:12]michelec2: ok let me see
[14:12]Slávek: The notification is when the media is inserted but is not when it is removed.
[14:12]cethyel: It's a replacement for Trinity Control Center
[14:12]michelec2: @Greg: help page not found
[14:12]cethyel: ok as I though
[14:13]cethyel: thanks!
[14:13]michelec2: @Slavek: yes, understood. that is why I am saying it seems to be a bug in my PR
[14:13]michelec2: @Greg: np (y)
[14:14]michelec2: @Slavek: I take you build and installed both tdelibs#144 and tdebase #219, right?
[14:14]Slávek: yes, both.
[14:15]michelec2: do you mount the device on insert?
[14:15]michelec2: or just insert without mounting?
[14:15]Slávek: cannot be mounted due to udisks2 × policykit.
[14:15]michelec2: ah yes, you can't mount because of udisks2 issue, right?
[14:15]michelec2: (y)
[14:16]michelec2: so the iso is in the VM cdrom unmounted, right?
[14:16]Slávek: yes, iso is inserted into VM cdrom.
[14:17]michelec2: wow, I find strange that you have a notification on insert then!
[14:17]michelec2: ok, I will try to replicate the same thing here and if I have more questions, I will ask over the weekend
[14:18]michelec2: notifications for insert should come either on "hardwareAdded" event or when /proc/mounts has changed
[14:20]michelec2: can you cat /proc/mounts before and after removing the cdrom and see if you notice any difference?
[14:21]Slávek: Because the medium is not mounted, it cannot affect /proc/mounts.
[14:22]michelec2: yes, that is why I find strange that you get insert notifications
[14:23]michelec2: for the remove notifications, I now understand. remove notifications with new PR are only on device removal, so if you have only change events, they will not be triggered
[14:23]Slávek: There will pop up notifications and a window asking to mount.
[14:24]michelec2: ah! you mean the dialog notification. how about tdehwdevicetray notification in the corner? do you get that on insert?
[14:24]michelec2: I guess we may have been talking about different notifications ;-)
[14:26]michelec2: in any case I am reasonably clear of the problem. In my system I get add/remove events when I insert an iso in the virtualbox cdrom. which is why I have notifications.
[14:27]michelec2: I will need to test on a real system with cdrom to see what I get
[14:27]michelec2: and eventually adjust the PR as necessary
[14:33]Slávek: notificaton from tdehwtray and also popup window asking what to do with a new device.
[14:34]michelec2: uhm... that is really weird then. it means a new device was added to the list of known devices but without a hardwareAdded event.
[14:35]michelec2: could you check the following thing?
1. without cd in virtual cdrom: run kdcop -> kded -> mediamanager -> fulllist and take note of existing disk devices
2. insert cdrom
3. repeat 1. and check what device was added
[14:36]michelec2: 4. remove cdrom
5. repeat 1. and check what device was removed, if any
[14:40]Slávek: Later, now I have to prepare and go shopping :)
[14:41]michelec2: sure, no rush. I am also going to sleep ;-)
[14:41]michelec2: have a good evening all.
[14:41]michelec2 has left
[14:41]Slávek: good night to you
[14:53]cethyel has left

tde-devs@chat.jabb.im < 2021/08/13 >