tde-devs@chat.jabb.im < 2021/11/24 >
[00:28]michelec2 has joined
[02:29]michelec2 has left
[02:29]michelec2 has joined
[03:29]michelec2 has left
[03:30]michelec2 has joined
[03:49]michelec2 has left
[06:37]cethyel has joined
[07:13]cethyel: Things are handled a bit differently in sip4-tqt and in python-tqt. For instance in sip4-tqt the directories "sipgen" and "siplib", each holds an *.sbf file. In order to change the name of the executable (sip=>sip-trinity), I changed the value of the target. Then I applied that to siplib. unfortunately those *.sbf files are created at build time in python-tqt but the Python siputils module from sip4-tqt is responsible to create them. see my last link, the method "generate_macros_and_rules" from the class "ModuleMakefile" is doing that job. It's not as easy as writing mfile.write("TARGET = %s\n" % ("t" + self._target + "." + ext)) because in this case the libraries in python-tqt wil have a "t" added as a prefix (EG: qt.so => tqt.so) but the library in sip4-tqt will get that prefix too, so whatever name in siplib.sbf is given as a target will end with an extra T. It boils down to the folder's name which hold the sip files to be processed (EG in python-tqt: qt, qtui, qtcanvas,etc). The target for the library will have the folder's name ( qt's folder => qt.so). I guess changing the folders name should do it though....or I add an extra "t" for everyone and the library "libsip.trinity.so" becomes "libtsip.so", qt.so => tqt.so, qtui.so => tqtui.so. I'd rather go that way, for consistency in sip4-tqt the executable could get an extra "t" too EG: sip => tsip
[07:49]Slávek: This seems an incorrect way to me. SIP-trinity should not change the name of the generated files. Here it should be renamed the source files in PyTQt.
[07:50]Slávek: For example, source file python-tqt/sip/qtcanvas/qcanvas.sip should be renamed to python-tqt/sip/tqtcanvas/tqcanvas.sip
[07:51]cethyel: there' is no connection between the sip files name and the resulting library name
[07:53]cethyel: configure.py from python-tqt goes into the sip folder, gather the directories there, check if there is sip files in them, then create an sbf file in each folders, this sbf file then creates a Makefile
[07:56]cethyel: at least there is no link with at build-time, afterwards these sip are installed on the system, but they go in /usr/share/"whatevername" we provide as an argument to configure.py
[07:57]cethyel: the default location for those sip file is set in sip4-tqt, EG /usr/share/sip-trinity, but once the location is provided to configure.py they where the packager want them
[07:59]Slávek: I assumed that if we change the directory name - such as python-tqt/sip/qt => python-tqt/sip/tqt, this will affect the result.
[08:00]cethyel: changing the directories name is a nightmare, I've just tried with one folder (qtui => tqtui) but It didn't work out, there are many occurences of qtui in several files/scripts
[08:02]Slávek: Yes, it will require a change and inside files where these sip files are used. But here does not make sense that the source directory and files remain named qt*, instead of tqt*.
[08:03]Slávek: It does not make sense that the resulting library for python is named qt-trinity.so instead of tqt.so.
[08:03]cethyel: the easiest way is to use siputils.py from sip4-tqt as such mfile.write("TARGET = %s\n" % ("t" + self._target + "." + ext)) it works, it adds a prefix "t" to every libs, qt.so => tqt.so, sip.so => tsip.so
[08:04]cethyel: that line can be used to add whatever prefix or suffix we want to the libs
[08:04]Slávek: Although it is a simple way, it seems wrong to me.
[08:05]Slávek: For example, from tdecore it create ttdecore.
[08:05]cethyel: there is no tdecore
[08:06]Slávek: tdecore is in python-trinity.
[08:06]cethyel: the libs in python-tqt are, qt.so, qtui.so, qtsql.so, etc, I guess qt.so is tdecore as we see It in tqt3
[08:07]Slávek: Adding prefix or suffix in sip-trinity affects both - PyTQt as well as PyTDE.
[08:07]cethyel: probably
[08:09]Slávek: Therefore, I believe that the change qt* => tqt* must be performed in PyTQt, not in sip-trinity.
[08:09]cethyel: i mean probably for PyTDE too, as I said python-tqt depends on sip4-tqt for a lot of things, the python scripts in python-tqt rely on python module from sip4-tqt
[08:10]cethyel: the way python-tqt is built depends on sip4-tqt, the building system is not independent
[08:10]blu.256 has left
[08:12]cethyel: well yesterday I red all the files and Python scripts in python-tqt (which is not easy for me since Python is new), I couldn't find where those sbf files were created, because the python module that creates them is in sip4-tqt
[08:17]cethyel: the Makefile that do the compiling of the sip files comes from those sbf files
[08:22]cethyel: I'll do It my way to give It a try, with your suggestion to rename the sip file as well EG qapplication.sip => tqapplication.sip, this should work since the Python scripts actually gather all the sip files from a directory, split them into *.cpp files (the number of *.cpp files depends on the argument we provide to configure), the splitting is directed in the sbf file as well as the naming of the resulting library, the install location, then a Makefile perform the compiling...
[08:30]cethyel: at first glance renaming the sip files with an extra t seems a lot of work, for little gain though
[08:33]Slávek: But there definitely does not make sense that the source files remained named qt* and the change of name was addressed elsewhere.
[08:34]Slávek: .Renaming could probably be done in bulk.
[08:40]cethyel: my primary concern was the renaming of the library in python-tqt like in the bug report from Michele, but you've just added an extra with the renaming of the those sip files. I have to make some test because I don't see any profit in this, at first glance when you script with python-tqt, you call a lib (named a module in Python vocab) EG import qt or import qtui then you write your code, I don't see a call to a sip file, everything must be handled by the binding
[08:42]cethyel: I'll do that tomorrow, don't have the courage to start this now, bye for now!
[08:42]cethyel has left
[08:42]Slávek: see you
[10:22]blu.256 has joined
[19:45]cethyel has joined
[19:45]cethyel has left
[21:57]blu.256 has left

tde-devs@chat.jabb.im < 2021/11/24 >