tde-devs@chat.jabb.im < 2022/02/07 >
[00:29]Slávek has joined
[01:20]Slávek: Great Philippe, tdemarkdown looks good, but I see one problem => use of md4c as a submodule instead of linking as a library.
[01:20]Slávek: At least it causes the following:
[01:20]Slávek: 1. Our scripts that provide automatic submodule update, would lead to uncontrolled submodule updates => as commits will come to GitHub.
[01:20]Slávek: 2. For stable branch, there is expected equally named branch on all submodules => it is not conceivable for a foreign module.
[12:40]michelec2 has joined
[13:00]blu.256: md4c is now included as a simple subdirectory rather than a submodule
[13:05]Slávek: I noticed, thank you.
[13:05]Slávek: BTW, is a reason for making a copy instead of linking a shared library?
[13:08]blu.256: Is there a reason to? Other programs I have seen using md4c use a copy directly too
[13:09]blu.256: For example, qt5 has a md4c copy under qtbase/src/3rdparty
[13:19]Slávek: In the future, we could add option to select whether to use a system md4c or buit-in copy.
[13:20]Slávek: In mentioned Qt5 is also availabled option "system-textmarkdownreader".
[13:22]blu.256: (Y)
[13:23]Slávek: For now build-in copy is a simplification, because of the older versions of Debian / Ubuntu md4c, it is not contained and the package had to be backported.
[15:52]michelec2 has left

tde-devs@chat.jabb.im < 2022/02/07 >