tde-devs@chat.jabb.im < 2022/04/19 >
[02:07]michelec2 has joined
[03:15]michelec2 has left
[09:21]Slávek has left
[10:20]Slávek has joined
[11:27]michelec2 has joined
[11:27]michelec2: @blu.256: I will progressively test your other PRs in the next days and report back
[11:27]michelec2: unfortunately still a very busy period
[13:51]michelec2 has left
[13:51]michelec2 has joined
[13:53]michelec2 has left
[13:58]Slávek: I think I came across the problem with TDEMarkdown.
[13:59]Slávek: There is used a TQByteArray and loading the file using TQFile.readAll().
https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/src/branch/master/tdemarkdown/markdown_part.cpp#L70
[14:00]Slávek: Subsequently, the data is passed to the MD4C parser: parse((MD_CHAR*) data.data())
[14:01]Slávek: I'm afraid that readAll does not use zero terminator at the end of the string in TQByteArray.
[14:02]Slávek: ... and strlen call can return the wrong value:
https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/src/branch/master/tdemarkdown/markdown_part.cpp#L99
[17:00]Slávek: See fix in TDE/tdelibs#159
[17:00]tde-bot: [TGW][tdelibs] #159 - tdemarkdown: Ensure that the loaded file content is terminated
https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/pulls/159
[18:05]blu.256 has joined
[18:05]blu.256 has left
[18:05]blu.256 has joined
[18:08]blu.256: Okay, the fix looks reasonable
[18:09]Slávek: With the indicated Fix I no longer observed "garbage" displayed at the end of the files.
[18:11]blu.256: I have been trying to track this problem for some time
[18:12]blu.256: I'll try the fix out and report on TGW
[18:12]Slávek: thank you
[18:13]Slávek: If the tests will be ok, I merge it when I'm back at the computer. Now I'll be away for a few hours.
[18:16]Slávek has left
[18:53]blu.256 has left
[18:53]blu.256 has joined
[18:54]blu.256 has left
[18:54]blu.256 has joined
[19:00]blu.256: Like before I get garbage in some files but not in others. For example in KlamAV Readme.md I'm still constantly getting a letter 'i', in TDEMarkdown's own README the garbage changes with every refresh and in a lot of other files (e.g. md4c readme or Amarok readme) there is no garbage at all. :/
[19:01]blu.256 has left
[22:58]Slávek has joined
[23:13]Slávek: Ok, thank you for the test, apparently it is not a complete solution to the problem. PR marked as WIP.

tde-devs@chat.jabb.im < 2022/04/19 >