tde-devs@chat.jabb.im < 2022/06/27 >
[06:31]blu.256: Hello Slávek, I will take a look at them later, and probably also re-squash into two commits instead of one.
[06:31]blu.256 has left
[07:15]blu.256 has joined
[07:16]blu.256 has left
[07:16]blu.256 has joined
[07:34]blu.256: I have made the changes you requested
[08:20]blu.256 has left
[09:10]michelec2 has joined
[09:19]blu.256 has joined
[09:19]blu.256 has left
[09:19]blu.256 has joined
[09:26]Slávek: Great, Pholippe, thank you. Additional question:
[09:28]Slávek: There are three parts commented out (#if 0 ... #endif) in the backported source code. Should we check if it was solved later?
[09:28]Slávek: For example part "// set modification time"
[09:51]blu.256: It's probably worth a look, but looks like it's not a blocker at present
[09:56]Slávek: I was particularly interested in the mentioned date/time modification settings. I have not tested, behavior - whether the time is maintained or not.
[09:57]Slávek: If the behavior has changed compared to the current state, users could report it as a problem.
[09:57]Slávek: In any case, PR looks good.
[10:05]michelec2: Hi Philippe
[10:05]michelec2: the security fix looks good
[10:06]michelec2: and thanks for fixing up that indentation ;-)
[10:09]michelec2: btw, TDE/tdebase#280 and TDE/tdebase#281 would also be nice fixes for the end users
[10:09]tde-bot: [TGW][tdebase] #281 - konqueror: "Set as Background" action on images applies wrong positioning
https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/issues/281
[10:09]tde-bot: [TGW][tdebase] #280 - kdesktop: default positioning of wallpapers ignores aspect ratio
https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/issues/280
[11:23]blu.256: Yes, I have seen the proposals
[11:24]blu.256: I'll merge the the 2 PRs once I'm at my computer
[11:25]blu.256: Meanwhile I also wanted to give TDE/tdebase#163 a try
[11:25]tde-bot: [TGW][tdebase] #163 - TCC displayconfig module gamma settings mess up the display
https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/issues/163
[11:30]michelec2: great, if you work on those 3 things it will be nice for R14.0.13 probably
[11:36]blu.256 has left
[13:43]michelec2 has left
[14:07]blu.256 has joined
[14:07]blu.256 has left
[14:08]blu.256 has joined
[14:54]blu.256: @Slávek I replaced find_package with pkg_search_module, is that right?
[15:46]Slávek: (Y)
[15:47]Slávek: I will test the build for some Debian versions and FreeBSD.
[16:30]blu.256: (Y)
[16:55]Slávek: Build on Debian 9 - Stretch => libssh 0.7.3
tdeio_sftp.cpp:646:52: error: 'ssh_get_server_publickey' was not declared in this scope
[16:58]Slávek: Note: On Ubuntu 16.04 (Xenial) is libssh version 0.6.3.
[17:00]Slávek: It seems, that for older version of libssh we need to use ssh_get_publickey instead of ssh_get_server_publickey.
[17:02]blu.256: (Y)
[17:04]blu.256 has left
[17:05]Slávek: ...and some other changes will be necessary :(
[17:06]Slávek: tdeio_sftp.cpp:653:41: error: 'SSH_PUBLICKEY_HASH_SHA256' was not declared in this scope
[17:12]Slávek: tdeio_sftp.cpp:662:47: error: 'ssh_session_is_known_server' was not declared in this scope
[17:12]Slávek: tdeio_sftp.cpp:664:10: error: 'SSH_KNOWN_HOSTS_OK' was not declared in this scope
[17:12]Slávek: in short - all SSH_KNOWN_HOSTS_* is not available in libssh 0.7.3.
[22:00]michelec2 has joined
[23:51]michelec2 has left

tde-devs@chat.jabb.im < 2022/06/27 >