#tde-devs < 2026/07/19 > |
| [07:22] | Fat-Zer has quit (Ping timeout: 276 seconds) |
| [07:35] | Fat-Zer has joined |
| [10:38] | micheleC has joined |
| [11:20] | SlavekB has quit (Quit: Kopete 0.12.7 : http://trinitydesktop.org) |
| [13:33] | Fat-Zer: micheleC: hey, sorry I didn't managed managed to review the TDE/tdegraphics/pulls/165 yesterday... overall it looks fine... but as I suggested on the PR it IMHO would be neater if flip/rotation arithmetic were encapsulated into a small dedicated class... I may do that on top of your branch if you wish... |
| [13:40] | micheleC: you mean the flip/rotation of imlib1? or of kuickimage? |
| [13:44] | Fat-Zer: yep |
| [13:53] | micheleC: I have updated the PR with feedback on your points. if you want to add your changes on top of it for review, feel free to go ahead. I am not quite sure I understand exactly how you are envisioning the code. |
| [13:53] | micheleC: so easier if you propose a version and I take a look |
| [13:54] | micheleC: rather than me guessing what you are looking at, propose something and start another 10 rounds of reviews :-) |
| [13:54] | micheleC: keep in mind that with imlib2 some of the functions will be simplified. for example imlib2 has proper rotate method and smooth scaling |
| [14:01] | Fat-Zer: ok, great |
| [14:05] | micheleC: I also have a fix for Kate crash. I am preparing PR |
| [14:40] | micheleC has quit (Quit: Kopete 0.12.7 : http://trinitydesktop.org) |
| [22:45] | SlavekB has joined |
© 2010-2026 Trinity Desktop Project