tde-devs@chat.jabb.im < 2021/06/23 >
[01:19]michelec2 has joined
[01:44]michelec2: for reference to existing users of this chat, this channel is now publicly logged too
[03:15]michelec2 has left
[11:36]cethyel has joined
[12:14]cethyel: Slávek is now Away, Slávek is now Online...up and down the road to the coffee machine I see ;-)
[12:15]Slávek: :)
[12:15]Slávek: Coffee will soon follow :)
[12:16]cethyel: made some adjustments in kopete-otr as you requested
[12:17]Slávek: As I see, you've already done what I have here in the first additional patch - resolving TQT_NO_COMPAT :)
[12:17]cethyel: ascïï casting is all yours ;-)
[12:18]Slávek: Sure, patch is already ready, waiting for your adjustments on PR :)
[12:25]Slávek: BTW for kopete_otr are as sources otrguiclient.cpp and otrplugin.cpp, which is the same as in kotr_commun2-static
[12:33]cethyel: I knew all along about the compiling of the same files twice but first I wanted to stay as close as possible to the Makefiles and I wanted a resulting lib as small as possible, so chose to push it that way, you can link the plugins with a big static lib too sine they all require functions from kotr-gui and kotr_commun1/2, but then what's the point in having plugins?
[12:35]Slávek: I also now explore what is the difference between the kotr library and kopete_otr module...
[12:39]cethyel: I also new for the ortlib >= 4.0.0.0 but i didn't think to invert the condiftion as you suggested, I had have a look on otrlib in Debia there, every release was shipped with otrlib>4.0.0 so I went the easy way
[12:39]Slávek: ... It seems that it needs a bit to rearrange, because now it is practically linked to all modules / libraries.
[12:40]cethyel: yes, that the problem i've facing from the start hence my split into kotr_gui, kotr_commun1...I chose to compile some files twice
[12:41]Slávek: If I remember well, VERSION_GREATER_EQUAL required a newer version of CMake than is in older distributions.
[12:41]Slávek: That is why I prefer NOT VERSION_LESS.
[12:42]cethyel: yes htat why i went for VERSION_GREATER, i believe it needs cmake 3.7
[12:49]cethyel: in tqt3 I have run into a blocker now because the SQL modules need some functions from the tqt3 lib itself, building everything as a static lib was convenient to progress in the build but now I have to switch to a shared lib. i still don't know what I'm going to do because i can compile a dummy file and gather/link everything with, but I have in mind something more modular a bit like a shared kernel lib, a shared gui lib, a shared network lib, etc with their own pkgconf files
[13:05]cethyel: Does it apprear appelling to you a tqt3 lib more modular, with several shared libs instead of one big lib?
[13:06]Slávek: Yes, it sounds like an interesting idea.
[13:08]Slávek: In any case, it will need to be carefully prepared because it will be a change in ABI == programs will have to be re-linked with a new libraries.
[13:08]cethyel: yes it will need a complete rebuild
[13:11]cethyel: I'm going offline for a while
[13:11]cethyel has left
[14:27]cethyel has joined
[15:04]Slávek: I have to say that I really don't understand how there can work building of kopete-otr with automake :)
[15:04]Slávek: I prepare small changes that bring a little order to it.
[15:14]cethyel: please wait i'm doing something...
[15:16]Slávek: I now have patches ready to rearrange the source files for linking and bringing a little order.
[15:16]cethyel: ok let's see what you've got up the sleive
[15:18]Slávek: You also did something in this regard?
[15:19]cethyel: i was making small static libs just with everything along what a traditional Makefiles do, then i intended to group what can be regrouped
[15:20]Slávek: I believe that I did in the order so that there is no need for small static libraries.
[15:20]cethyel: it's shitty because as you said the automake build is rather weird
[15:28]Slávek: well, you can see new commits in TDE/kopete-otr#1
[15:28]tde-bot: [TGW][kopete-otr] #1 - WIP:Conversion to the cmake building system.
https://mirror.git.trinitydesktop.org/gitea/TDE/kopete-otr/pulls/1
[15:30]Slávek: Once you revise it, we can change the order of commits and do squash.
[15:35]cethyel: at least it builds and the the build is a lot cleaner :yes:
[15:37]Slávek: One possible improvement: We can create kotr_kcfgc-static library with source kopete_otr.kcfgc. And then link this small library to both kotr library and kcm_kopete_otr.
[15:38]Slávek: This can prevents repetitive buildings kopete_otr.cpp.o
[15:41]Slávek: see TDE/kopete-otr@b9f93816f
[15:41]tde-bot: [TGW][kopete-otr] Use small kotr_kcfgc-static library to prevent repetitive build of kopete_otr.cpp.o. · b9f93816ff
https://mirror.git.trinitydesktop.org/gitea/TDE/kopete-otr/commit/b9f93816f
[15:42]Slávek: :D wrong comment for kotr_kcfgc-static
[15:42]Slávek: ...but it doesn't matter because we do squash.
[15:43]cethyel: I did make a package out of your last commit, kopete-otr otr plugin works at least the gui
[15:47]Slávek: Great, we have successfully introduced order to source files structure (Y)
[15:47]cethyel: can you push the ascïï cast fix?
[15:48]Slávek: See TDE/kopete-otr@4e636f3
[15:48]tde-bot: [TGW][kopete-otr] Added controlled conversions to char* instead of automatic ascii conversions. · 4e636f3a74
https://mirror.git.trinitydesktop.org/gitea/TDE/kopete-otr/commit/4e636f3
[15:53]cethyel: kopete seems to work :yes:
[15:55]cethyel: the automake build works too, i haven't made a package though
[15:57]Slávek: I think, this also resolves bug 1153.
[15:57]tde-bot: [Bug 1153] Build issue: kopete-otr ftbfs when --no-undefined is set
https://bugs.trinitydesktop.org/show_bug.cgi?id=1153
[15:59]Slávek: ...so into commit log for TDE/kopete-otr@d047f91f5c can be added information about that.
[15:59]tde-bot: [TGW][kopete-otr] Separate OTRPlugin object code from the OTRPluginFactory definition. · d047f91f5c
https://mirror.git.trinitydesktop.org/gitea/TDE/kopete-otr/commit/d047f91f5c
[16:00]cethyel: possibly because it's a lot alike those errors I saw along the conversion
[16:00]Slávek: (Y)
[16:00]Slávek: ...and exactly why I wondered how building with automake can work.
[16:02]cethyel: how do you see the next move? should i squash with the little fix on the comment, then can I upload this into kopete (without the automake stuff)?
[16:03]Slávek: You do squash and small fixes in the comments and in commit log to allow complete CMake conversion.
[16:05]Slávek: Once it is completed, we can move forward to insert code into the tdenetwork.
[16:05]cethyel: I'm going to put this work in tdenetwork/kopete/plugins/kopete_otr
[16:06]Slávek: Yes, that's the right place (Y)
[16:07]Slávek: Possible directory in plugins can be named simply 'otr'.
[16:10]cethyel: yes
[16:40]cethyel: I'll let you have a last look at It, once you've done your merge things, I'll be back on It. I'm logging out for the moment.
[16:40]cethyel has left
[17:32]Slávek: In TDE/kopete-otr#1 I made one more editing. Commit that solves bug 1153, I left as a separate commit.
[17:32]tde-bot: [TGW][kopete-otr] #1 - Conversion to the cmake building system.
https://mirror.git.trinitydesktop.org/gitea/TDE/kopete-otr/pulls/1
[17:33]Slávek: At the same time, I changed the order so that the CMake conversion is now on the top of others.
[17:34]Slávek: It has no impact on the code - it remained unchanged from the previous state of PR.
[17:50]tde-bot has joined
[18:40]tde-bot has joined

tde-devs@chat.jabb.im < 2021/06/23 >