tde-devs@chat.jabb.im < 2021/08/15 > |
|---|
| [04:08] | Slávek has left |
| [04:08] | Slávek has joined |
| [11:10] | Slávek has left |
| [11:23] | michelec2 has joined |
| [11:24] | michelec2: @Slavek: I have updated TDE/tdebase#219. Now you should see correct notifications for CD too. |
| [11:24] | tde-bot: [TGW][tdebase] #219 - Updated after changes to tdehw lib related to device notificaitons.
https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/pulls/219 |
| [11:24] | michelec2: please test when you have a chance |
| [12:12] | Slávek has joined |
| [12:13] | michelec2 has left |
| [12:13] | michelec2 has joined |
| [12:49] | Slávek: On attach is notification about:
QEMU DVD-ROM (/dev/sr0) |
| [12:49] | Slávek: On detach is notification about:
iso9660 (/dev/sr0) |
| [12:50] | michelec2: it uses the device friendly name available at the time |
| [12:50] | michelec2: for attached: available at the time of attachment |
| [12:51] | michelec2: for detach: available at the time the device was last added to the known device list, which is either at attach time or at changes |
| [12:51] | Slávek: Name in popup window is: Slax - Trinity (amd64) |
| [12:52] | michelec2: yes |
| [12:52] | Slávek: iso9660 seems like filesystem type |
| [12:52] | michelec2: we could use something different from sdevice->friendlyName |
| [12:53] | michelec2: let me explore some options and I can come back with some choices. then we can discuss further |
| [12:53] | Slávek: ok, thank you |
| [12:55] | Slávek: BTW, in tdehwtray menu is also mentioned QEMU DVD-ROM. Only notification on detach say iso9660 |
| [12:56] | michelec2: ah! it's a typo. I used wrong function when I added it in the map |
| [12:57] | michelec2: I used sdevice->fileSystemName() instead of sdevice->friendlyName() |
| [12:59] | michelec2: but it is not enough to change that, I see different names when testing with disks. |
| [13:02] | michelec2: I think the best solution is to preverve the data added at the time of the 'added' notification |
| [13:02] | michelec2: so that the two events will match |
| [13:49] | michelec2: I have updated the PR again |
| [13:49] | michelec2: now the values used at "added" notification will be remembered and used on removal, so the names will match |
| [13:49] | michelec2: for the name I use the disk label if avaiable, otherwise the friendly name. |
| [13:50] | michelec2: disk label is needed for cdrom, friendlyname for hard disks |
| [13:50] | michelec2: and will basically provide the name use in the notification dialog with actions |
| [13:52] | michelec2: the only exception seems to be LUKS DVD for which virtualbox CDROM will still be used in the devicetray notifications. but Slax and other disks now shows up with the cdrom name |
| [14:00] | michelec2: usb disk will display the label if defined, otherwise it seems to show up as usb flash drive |
| [14:01] | michelec2: I have not tried a usb disk with two partitions on it, I need to make one again |
| [14:06] | michelec2: ok, with two partitions, the partition label is correctly used |
| [14:06] | Slávek: (Y) |
| [14:07] | Slávek: I'll do the test and then it seems ready. |
| [14:07] | michelec2: (y) I am going for a walk. you can leave a message here or on the PR |
| [14:08] | michelec2: looks like tomorrow we can finally merge this two PRs. They fix 3 points in my TODO list for bug 2273 ;-) |
| [14:08] | tde-bot: [Bug 2273] Add support for LUKS in next TDE minor release
https://bugs.trinitydesktop.org/show_bug.cgi?id=2273 |
| [14:08] | michelec2: have a good evening |
| [14:08] | Slávek: thanks |
| [14:08] | Slávek: good walk and night to you |
| [14:08] | michelec2: thanks |
| [14:08] | michelec2 has left |
| [16:04] | Slávek has left |
| [16:08] | Slávek has joined |
| [17:11] | Slávek: Current commit in TDE/tdebase#219 tested - works well. I added a small commit to use the disk label consistently also in the tray menu. |
| [17:11] | tde-bot: [TGW][tdebase] #219 - Updated after changes to tdehw lib related to device notificaitons.
https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/pulls/219 |
| [18:15] | cethyel has joined |
| [18:15] | Slávek has left |
| [18:16] | Slávek has joined |
| [18:18] | cethyel: Slávek, can you correct the spelling in README tde-systemsettings, --> the Trinity Control
Centre/Center ? |
| [18:20] | cethyel: Thanks in advance. see you next week |
| [18:20] | cethyel has left |
| [19:38] | Slávek has left |
| [19:39] | Slávek has joined |
| [21:08] | Slávek has left |
| [21:37] | Slávek has joined |
tde-devs@chat.jabb.im < 2021/08/15 > |
|---|
