tde-devs@chat.jabb.im < 2021/10/05 >
[00:59]michelec2 has joined
[01:17]michelec2: Hi Philippe, a couple of things to fix in the TDE menu search box config page
[01:18]michelec2: 1) if the checkbox to show the search box is not checked, it makes no sense to select the shortcut for it. So after discussing it with Slavek, we think it would make sense to gray it out if the checkbox is not checked
[01:19]michelec2: 2) when you open the dialog to set the shortcut and select the shortcut, the dialog closes on its own. This means if we need to set two shortcuts, the user has to open the dialog again. Not sure if this is a problem only on my system or if it works like this on yours too
[01:23]Slávek: This is the normal behavior of the window to specify the keyboard shortcut.
[01:27]michelec2: :-( I never noticed that before. There are OK/Cancel buttons in the dialog, I would not expect the dialog to close automatically
[01:27]michelec2: maybe worth considering to change this behavior??
[01:28]Slávek: I don't know if it is a good idea - users are likely to be accustomed to such behavior.
[01:29]michelec2: yeah, that's true.... probably better leave it as it is then.
[01:30]michelec2: so only point 1) applies
[01:30]Slávek: Perhaps there may be behavior different depending on whether Advanced options are displayed => possibility to enter two keyboard shortcuts.
[01:31]Slávek: In any case, if we wanted to make such a change, it will be better to postpone it for later.
[01:31]Slávek: so, yes, only point 1) applies for now
[01:33]michelec2: @different behavior: I also thought so. But it's a small thing, as you mentioned users are probably accustomed to it and not a top priority.
[02:23]michelec2 has left
[07:49]blu.256: Hello, I just pushed the fix for the checkbox issue (thanks for noting) and another one which adds a check that the shortcut is not Escape (which it can't be).
[07:50]Slávek: great, thank you
[09:22]Slávek has left
[10:14]Slávek has joined
[11:42]michelec2 has joined
[11:42]michelec2: thanks Philippe
[11:43]michelec2: commits looks nice and clean (y)
[12:01]cethyel has joined
[12:09]michelec2 has left
[12:10]michelec2 has joined
[12:12]michelec2 has left
[12:22]michelec2 has joined
[12:48]cethyel has left
[12:49]cethyel has joined
[13:29]cethyel: Slávek, on Debian do you have a user environment variable such as QT_HOME_DIR defined ? or a system one like QT_SYSTEM_DIR?
[13:29]Slávek: no, these variable are not defined
[13:29]cethyel: so they are meaningless in the code too
[13:50]michelec2 has left
[13:52]michelec2 has joined
[13:52]cethyel: not going for a ride today Michele?
[13:53]michelec2: @Philippe: I can still use Escape as shortcut for the search menu field if I first define another shortcut. For example I can get "Space;Escape" or "Escape;Space"
[13:53]michelec2: also if only one shortcut is used and I type Escape, it is ignored as per your last commit but there is no feedback to the user, who is left to wonder why Escape was not used
[13:54]michelec2: @Greg: should go but don't feel good, so I will go to sleep in a minute
[13:54]michelec2: @Philippe: grey out of the shortcut button works fine, thanks!
[13:55]michelec2: going to sleep, see you all
[13:55]cethyel: have good sleep then, be careful with covid-19 vaccine symptoms
[13:55]michelec2: (y) thanks
[13:55]michelec2: and have a good evening
[13:55]cethyel: :yes:
[13:55]michelec2 has left
[13:56]cethyel: I'll be going too, bye!
[13:56]cethyel has left
[14:11]tde-bot has left
[14:14]tde-bot has joined
[14:21]tde-bot has left
[14:23]tde-bot has joined
[14:23]blu.256 has joined
[14:43]Slávek has joined
[16:31]Slávek has left
[16:55]blu.256: @Michele Thank you for your comments, hopefully will fix these tomorrow. I'm not so sure about how to go with the feedback part, so I'll probably create a PR for this.
[17:19]Slávek has joined
[18:05]Slávek has left
[22:37]Slávek has joined
[23:03]tde-bot has left
[23:03]tde-bot has joined
[23:16]tde-bot has left
[23:17]tde-bot has joined
[23:19]blu.256 has joined

tde-devs@chat.jabb.im < 2021/10/05 >