tde-devs@chat.jabb.im < 2021/11/16 >
[00:01]blu.256: @merge I just blindly used the "Update branch" button on Gitea, hence the master merge commit
[00:32]michelec2 has joined
[00:33]michelec2: ah I see. I think once I tried that too and after seeing the result I havne't used anymore.. No prob, easy to remove it when you squash
[00:33]michelec2: I am going to give another test in a short while
[01:57]michelec2: last test seems worse than before. see comment on PR
[02:57]michelec2 has left
[02:57]michelec2 has joined
[03:39]michelec2 has left
[07:35]blu.256: I think it must have picked the icons from the theme or else it would have fallen back to Kweathers ones. Its just the issue with SVG icons I commented on PR
[07:37]blu.256: You could try testing with Oxygen (it has PNG icons) or Crystal (it doesn't have weather icons at all, so should fall back to KWeather's)
[08:45]blu.256 has left
[11:31]blu.256 has joined
[15:16]michelec2 has joined
[15:17]michelec2: With Crystal it works fine, I see the icons.
[15:18]michelec2: but the point is "if we are going to do changes to tdetoys to improve icon names, we need to make sure we don't break things that were already working". Before I didn't have issues even when using Masalla
[15:39]michelec2 has left
[16:10]blu.256: Yes, sure, but before KWeather did not actually use icons from Masalla. With this PR (which, as you can see, still doesn't fully work as intended) KWeather will be able to use icons from the current icon theme. The last piece to this puzzle is making KWeather able to display SVG icons. I'll let you know when you can test this PR again :-)

tde-devs@chat.jabb.im < 2021/11/16 >